[Nginx] Add NGINX CLI by limingu · Pull Request #5305 · Azure/azure-cli-extensions

limingu · 2022-09-02T23:12:41Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

yonzhan · 2022-09-02T23:32:09Z

Nginx

…update,show,list

…s for certificates

…ensions into nginx62022

kairu-ms

Please add examples for commands

src/nginx/azext_nginx/azext_metadata.json

policy.json

src/nginx/azext_nginx/_help.py

src/nginx/azext_nginx/_params.py

src/nginx/setup.py

kairu-ms · 2022-09-16T05:14:32Z

src/nginx/azext_nginx/azext_metadata.json

@@ -0,0 +1,4 @@
+{
+    "azext.isExperimental": true,


Do you want to release this extension in experimental, preview or GA?

GA. Changing this to false

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

…ensions into nginx62022

kairu-ms · 2022-09-20T05:52:49Z

src/nginx/azext_nginx/_help.py

+helps['nginx deployment list'] = """
+    type: command
+    short-summary: "List all Nginx Deployments under the specified resource group; List all deployments under the specified subscription."
+    examples:
+      - name: Deployments_ListByResourceGroup
+        text: |-
+               az nginx deployment list --resource-group myResourceGroup
+      - name: Deployments_List
+        text: |-
+               az nginx deployment list
+"""


Because you use aaz-dev-tools to generate atomic commands. You should add examples and summaries in aaz-dev-tools. When you generate code, that information will be contained in the Command class description. Instead of writing them in _help.py file.

Please create a PR to submit the atomic command models in aaz as well.

Created PR Azure/aaz#24

Because you use aaz-dev-tools to generate atomic commands. You should add examples and summaries in aaz-dev-tools. When you generate code, that information will be contained in the Command class description. Instead of writing them in _help.py file.

Oh. Thanks for this. Done

src/nginx/azext_nginx/azext_metadata.json

kairu-ms · 2022-09-20T05:56:37Z

Please create a PR to submit the atomic command models in aaz as well.

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

src/nginx/azext_nginx/aaz/latest/nginx/deployment/_create.py

kairu-ms · 2022-09-21T06:49:53Z

src/nginx/azext_nginx/aaz/latest/nginx/deployment/certificate/_create.py

+    parameters:
+          - name: --certificate-path
+            This path must match one or more ssl_certificate_key directive file argument in your Nginx configuration. This path must be unique between certificates within the same deployment
+          - name: --key-path
+            This path must match one or more ssl_certificate directive file argument in your Nginx configuration. This path must be unique between certificates within the same deployment
+          - name: --key-vault-secret-id
+            The secret ID for your certificate from Azure Key Vault


Parameter help message should be in the argument short-summery or long-summery in aaz-dev-tools.

Done. I've also updated this on the aaz repo PR

src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuration/_create.py

src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuration/_update.py

src/nginx/azext_nginx/aaz/latest/nginx/deployment/_update.py

…n/_create.py Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

…n/_update.py Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

wangzelin007 · 2022-09-26T13:16:05Z

/azp run

azure-pipelines · 2022-09-26T13:16:18Z

Azure Pipelines successfully started running 1 pipeline(s).

george-ngugi · 2022-09-26T17:20:10Z

/azp run

azure-pipelines · 2022-09-26T17:20:17Z

Commenter does not have sufficient privileges for PR 5305 in repo Azure/azure-cli-extensions

kairu-ms · 2022-09-27T06:30:16Z

/azp run

azure-pipelines · 2022-09-27T06:30:27Z

Azure Pipelines successfully started running 1 pipeline(s).

azclibot · 2022-09-27T07:39:49Z

[Release] Update index.json for extension [ nginx ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6256&view=results

limingu and others added 3 commits September 2, 2022 14:52

[Nginx] Add NGINX cli

4da95cc

Update

e684a38

Merge branch 'main' into nginx62022

3061390

yonzhan requested review from jsntcy and kairu-ms September 2, 2022 23:32

yonzhan assigned kairu-ms Sep 2, 2022

yonzhan added this to the Sep 2022 (2022-10-12) - For Ignite milestone Sep 2, 2022

george-ngugi and others added 10 commits September 9, 2022 23:25

Add missing queryparam api-version;Write tests for deployment create,…

113dc40

…update,show,list

commit recordings;add apiversion query param to cert actions;add test…

b798402

…s for certificates

delete recordings

ea1b31f

make cert tests work

8dd0f81

add config apiversion query params;add config tests; test recording

b3e863a

fix conflict in owners

0847fee

fix github owners conflict; remove deprecated test

7e3a8f8

add new line

b2de509

add new line

e372c53

Merge branch 'main' into nginx62022

678411a

limingu changed the title ~~[Nginx] Add NGINX cli~~ [Nginx] Add NGINX CLI Sep 14, 2022

george-ngugi added 3 commits September 15, 2022 01:29

make lint changes;add fresh test recordings

d752b02

Merge branch 'nginx62022' of https://github.com/limingu/azure-cli-ext…

3783b52

…ensions into nginx62022

add az nginx to service names

f4270db

kairu-ms requested changes Sep 16, 2022

View reviewed changes

george-ngugi and others added 7 commits September 19, 2022 16:37

Update src/nginx/setup.py

8c419da

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

Update src/nginx/azext_nginx/azext_metadata.json

4154afd

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

Remove policy.json test generated file

e3ab0c5

edit src/nginx/azext_nginx/_help.py as not required

73196ed

remove cmds in params.py

c2dad3a

Merge branch 'nginx62022' of https://github.com/limingu/azure-cli-ext…

40071bc

…ensions into nginx62022

Add help

470a6e8

george-ngugi added 3 commits September 19, 2022 21:23

fix linter white space issues

6d7e22e

fix linter white space issues

cd40f0d

Add link for sku

b94329a

kairu-ms reviewed Sep 20, 2022

View reviewed changes

src/nginx/azext_nginx/azext_metadata.json Outdated Show resolved Hide resolved

george-ngugi and others added 2 commits September 20, 2022 09:50

Update src/nginx/azext_nginx/azext_metadata.json

3b91a43

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

help cmds from aaz models;new test recording

d65f693

kairu-ms reviewed Sep 21, 2022

View reviewed changes

src/nginx/azext_nginx/aaz/latest/nginx/deployment/_create.py Outdated Show resolved Hide resolved

kairu-ms reviewed Sep 21, 2022

View reviewed changes

src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuration/_create.py Outdated Show resolved Hide resolved

george-ngugi added 2 commits September 21, 2022 11:20

Remove paramter info

352a529

Remove policy generated file

134e7f0

kairu-ms reviewed Sep 26, 2022

View reviewed changes

src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuration/_create.py Outdated Show resolved Hide resolved

kairu-ms reviewed Sep 26, 2022

View reviewed changes

src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuration/_update.py Outdated Show resolved Hide resolved

kairu-ms reviewed Sep 26, 2022

View reviewed changes

src/nginx/azext_nginx/aaz/latest/nginx/deployment/_update.py Outdated Show resolved Hide resolved

george-ngugi and others added 3 commits September 26, 2022 14:11

Update src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuratio…

d10e30a

…n/_create.py Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

Update src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuratio…

300da8f

…n/_update.py Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

Update src/nginx/azext_nginx/aaz/latest/nginx/deployment/_update.py

acc509b

Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>

george-ngugi added 2 commits September 26, 2022 19:57

Use shorthand syntax expression

a8cb6a2

Give meaningful update examples

d182fa1

kairu-ms approved these changes Sep 27, 2022

View reviewed changes

kairu-ms merged commit f947976 into Azure:main Sep 27, 2022

Conversation

limingu commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

yonzhan commented Sep 2, 2022

Uh oh!

kairu-ms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kairu-ms Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

george-ngugi Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kairu-ms Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

george-ngugi Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

george-ngugi Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kairu-ms commented Sep 20, 2022

Uh oh!

Uh oh!

kairu-ms Sep 21, 2022

Choose a reason for hiding this comment

Uh oh!

george-ngugi Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangzelin007 commented Sep 26, 2022

Uh oh!

azure-pipelines bot commented Sep 26, 2022

Uh oh!

george-ngugi commented Sep 26, 2022

Uh oh!

azure-pipelines bot commented Sep 26, 2022

Uh oh!

kairu-ms commented Sep 27, 2022

Uh oh!

azure-pipelines bot commented Sep 27, 2022

Uh oh!

azclibot commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

limingu commented Sep 2, 2022 •

edited

Loading

george-ngugi Sep 19, 2022 •

edited

Loading

kairu-ms Sep 20, 2022 •

edited

Loading

george-ngugi Sep 21, 2022 •

edited

Loading